Bug 209335

Summary: [MSE][GStreamer] Clean and explain first sample PTS hack
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2020-03-20 06:10:13 PDT
MediaSample::applyPtsOffset() had a rather confusing name, so it has been changed to something more descriptive of its actual function: extendToTheBeginning(). Also, its only argument has been removed, as it's always zero. An explanation of the hack has also been added. This patch introduces no behavior changes.
Attachments
Patch (5.54 KB, patch)
2020-03-20 10:40 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2020-03-20 10:40:21 PDT
Created attachment 394101 [details] Patch
EWS
Comment 2 2020-03-23 08:27:43 PDT
Committed r258844: <https://trac.webkit.org/changeset/258844> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394101 [details].
Note You need to log in before you can comment on or make changes to this bug.