Summary: | [ews] commit-queue should comment on bug if patch fails to apply | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2020-03-20 06:05:52 PDT
Created attachment 394080 [details]
Patch
Sample runs: Commit-queue: https://ews-build.webkit-uat.org/#/builders/26/builds/1611 Other queue: https://ews-build.webkit-uat.org/#/builders/14/builds/934 Comment on attachment 394080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394080&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:230 > + message = 'Patch {} does not apply'.format(patch_id) Shouldn't we define the message only if the return-code is a failure? Committed r258760: <https://trac.webkit.org/changeset/258760> > Shouldn't we define the message only if the return-code is a failure?
Done
|