Bug 209318

Summary: REGRESSION (r258707): storage/indexeddb/cursor-leak.html is flaky timing out
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, jsbell, rniwa, sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209256
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jacob Uphoff 2020-03-19 15:47:14 PDT 
storage/indexeddb/cursor-leak.html

This test started to flaky timeout after commit r258707 for wk2.

History:

https://results.webkit.org/?suite=layout-tests&test=storage%2Findexeddb%2Fcursor-leak.html

Diff:

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-actual.txt
@@ -1,15 +1,5 @@
-Verify that that cursors weakly hold script value properties
+#PID UNRESPONSIVE - WebKitTestRunner (pid 75029)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
-
-indexedDB.deleteDatabase(dbname)
-indexedDB.open(dbname)
-PASS cursorObservers.length is 10000
-PASS anyCollected is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF
Comment 1 Radar WebKit Bug Importer 2020-03-19 15:47:52 PDT 
<rdar://problem/60657081>
Comment 2 Jacob Uphoff 2020-03-19 16:27:13 PDT 
Set expectations here: https://bugs.webkit.org/show_bug.cgi?id=209318
Comment 3 Jacob Uphoff 2020-03-19 16:29:51 PDT 
I don't think this is worth rolling out the commit because it did fix one of the two tests, and the other test is no longer flaky but it is timing out now.
Comment 4 Jacob Uphoff 2020-03-19 16:39:18 PDT 
Looks like this is also timing out on wk1. SO set new expectations here: https://trac.webkit.org/changeset/258742/webkit
Comment 5 Ryosuke Niwa 2020-03-19 17:06:16 PDT 
Maybe 10,000 is a bit too high of a number. Maybe try 1000?
Comment 6 Sihui Liu 2020-03-19 21:42:10 PDT 
Created attachment 394067 [details]
Patch
Comment 7 EWS 2020-03-20 10:27:04 PDT 
Committed r258768: <https://trac.webkit.org/changeset/258768>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394067 [details].
Comment 8 Sihui Liu 2020-03-20 15:33:55 PDT 
Reopening to attach new patch.
Comment 9 Sihui Liu 2020-03-20 15:33:56 PDT 
Created attachment 394138 [details]
Patch for landing
Comment 10 EWS 2020-03-20 15:56:15 PDT 
Committed r258797: <https://trac.webkit.org/changeset/258797>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394138 [details].
Comment 11 Ryosuke Niwa 2020-03-20 17:18:08 PDT 
Woot! Looks like the flakiness is gone!