Summary: | Upstream a variety of Cocoa-platform HAVE and ENABLE macros | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||||||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | aestes, benjamin, cdumez, cmarcelo, ews-watchlist, jacob_uphoff, keith_miller, mark.lam, megan_gardner, msaboff, saam, simon.fraser, tzagallo, webkit-bug-importer, wenson_hsieh | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Tim Horton
2020-03-19 14:18:11 PDT
Created attachment 394023 [details]
Patch
Created attachment 394024 [details]
Patch
Comment on attachment 394024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394024&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:269 > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > Source/WTF/wtf/PlatformEnableCocoa.h:275 > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Ditto. Created attachment 394027 [details]
Patch
(In reply to Andy Estes from comment #3) > Comment on attachment 394024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394024&action=review > > > Source/WTF/wtf/PlatformEnableCocoa.h:269 > > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > > > Source/WTF/wtf/PlatformEnableCocoa.h:275 > > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Ditto. It sure is! Created attachment 394029 [details]
Patch
Created attachment 394030 [details]
Patch
Created attachment 394032 [details]
Patch
Created attachment 394034 [details]
Patch
Comment on attachment 394034 [details]
Patch
r=mews
Created attachment 394038 [details]
Patch
we'll get there someday Created attachment 394041 [details]
Patch
Created attachment 394045 [details]
Patch
Created attachment 394047 [details]
Patch
Created attachment 394049 [details]
Patch
Committed r258748: <https://trac.webkit.org/changeset/258748> Reverted r258748 for reason: This commit broke the Catalina build Committed r258765: <https://trac.webkit.org/changeset/258765> Committed r258772: <https://trac.webkit.org/changeset/258772> |