Bug 209307

Summary:

Upstream a variety of Cocoa-platform HAVE and ENABLE macros

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, benjamin, cdumez, cmarcelo, ews-watchlist, jacob_uphoff, keith_miller, mark.lam, megan_gardner, msaboff, saam, simon.fraser, tzagallo, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	aestes: review+

Tim Horton

Reported 2020-03-19 14:18:11 PDT

Upstream a variety of Cocoa-platform HAVE and ENABLE macros

Attachments
Patch (6.63 KB, patch) 2020-03-19 14:18 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (8.59 KB, patch) 2020-03-19 14:51 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (9.46 KB, patch) 2020-03-19 14:59 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (9.80 KB, patch) 2020-03-19 15:03 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (9.95 KB, patch) 2020-03-19 15:04 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (9.98 KB, patch) 2020-03-19 15:05 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (9.05 KB, patch) 2020-03-19 15:12 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (10.09 KB, patch) 2020-03-19 15:41 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (10.66 KB, patch) 2020-03-19 15:53 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (11.14 KB, patch) 2020-03-19 16:40 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (17.68 KB, patch) 2020-03-19 17:08 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (18.28 KB, patch) 2020-03-19 17:52 PDT, Tim Horton	aestes: review+	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2020-03-19 14:18:54 PDT

Created attachment 394023 [details] Patch

Tim Horton

Comment 2 2020-03-19 14:51:01 PDT

Created attachment 394024 [details] Patch

Andy Estes

Comment 3 2020-03-19 14:58:01 PDT

Comment on attachment 394024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394024&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:269 > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > Source/WTF/wtf/PlatformEnableCocoa.h:275 > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Ditto.

Tim Horton

Comment 4 2020-03-19 14:59:53 PDT

Created attachment 394027 [details] Patch

Tim Horton

Comment 5 2020-03-19 15:00:41 PDT

(In reply to Andy Estes from comment #3) > Comment on attachment 394024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394024&action=review > > > Source/WTF/wtf/PlatformEnableCocoa.h:269 > > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > > > Source/WTF/wtf/PlatformEnableCocoa.h:275 > > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Ditto. It sure is!

Tim Horton

Comment 6 2020-03-19 15:03:00 PDT

Created attachment 394029 [details] Patch

Tim Horton

Comment 7 2020-03-19 15:04:40 PDT

Created attachment 394030 [details] Patch

Tim Horton

Comment 8 2020-03-19 15:05:54 PDT

Created attachment 394032 [details] Patch

Tim Horton

Comment 9 2020-03-19 15:12:24 PDT

Created attachment 394034 [details] Patch