Bug 20927

Summary: simplify/streamline the code to turn strings into identifiers while parsing
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch mjs: review+

Darin Adler
Reported 2008-09-18 17:09:05 PDT
The code to parse JavaScript currently creates an unnecessary extra UString and then later turns it into an Identifier. This can be streamlined to be simpler, slightly less code, and slightly faster.
Attachments
patch (16.33 KB, patch)
2008-09-18 17:33 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (9.46 KB, patch)
2008-09-18 17:35 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-09-18 17:33:59 PDT
Created attachment 23545 [details] patch
Darin Adler
Comment 2 2008-09-18 17:35:26 PDT
Created attachment 23546 [details] patch
Maciej Stachowiak
Comment 3 2008-09-18 23:24:21 PDT
Comment on attachment 23546 [details] patch r=me
Darin Adler
Comment 4 2008-09-18 23:32:48 PDT
http://trac.webkit.org/changeset/36660
Note You need to log in before you can comment on or make changes to this bug.