Bug 209259

Summary: Allow for some tolerance when checking canvas pixels in fast/mediastream tests
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209205
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Eric Carlson
Reported 2020-03-18 17:10:14 PDT
Allow for some tolerance when checking canvas pixels in fast/mediastream tests
Attachments
Patch (6.60 KB, patch)
2020-03-18 17:14 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2020-03-19 12:53 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2020-03-19 13:13 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.78 KB, patch)
2020-03-19 13:26 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2020-03-19 14:12 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-18 17:10:25 PDT
<rdar://problem/60609789>
Eric Carlson
Comment 2 2020-03-18 17:14:35 PDT
Created attachment 393921 [details] Patch
EWS
Comment 3 2020-03-19 08:34:12 PDT
Committed r258700: <https://trac.webkit.org/changeset/258700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393921 [details].
Eric Carlson
Comment 4 2020-03-19 12:53:11 PDT
Reopening to attach new patch.
Eric Carlson
Comment 5 2020-03-19 12:53:12 PDT
Created attachment 394007 [details] Patch
EWS
Comment 6 2020-03-19 12:54:43 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Eric Carlson
Comment 7 2020-03-19 13:13:19 PDT
Created attachment 394010 [details] Patch
EWS
Comment 8 2020-03-19 13:14:35 PDT
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Eric Carlson
Comment 9 2020-03-19 13:26:34 PDT
Created attachment 394013 [details] Patch
Eric Carlson
Comment 10 2020-03-19 14:12:50 PDT
Created attachment 394022 [details] Patch
EWS
Comment 11 2020-03-19 16:05:30 PDT
Committed r258739: <https://trac.webkit.org/changeset/258739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394022 [details].
Note You need to log in before you can comment on or make changes to this bug.