| Summary: | [ews] commit-queue should comment on bug in case of test failures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209227 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 201934 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-03-18 06:45:02 PDT
Created attachment 393845 [details]
Patch
Comment on attachment 393845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393845&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1830 > + self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()]) Is this the current behavior? If I recall, this logic doesn't apply to flaky tests, but I can see some circumstances where this behavior is undesirable. (In reply to Jonathan Bedard from comment #3) > Is this the current behavior? If I recall, this logic doesn't apply to flaky tests. Yes, I think so. The comment and cq- would be when a test failure is confirmed (test consistently failed in first and second run, and passed in clean-tree-run). Test which were found to be flaky during the run would not affect the result. Committed r258652: <https://trac.webkit.org/changeset/258652> This change seems to be working fine. Patch with test failure: https://ews-build.webkit.org/#/builders/28/builds/63 Flaky test: https://ews-build.webkit.org/#/builders/28/builds/66 |