Summary: | [CMake] libopus 1.1 its enough for building WebKitGTK with ENABLE_WEB_RTC | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebKitGTK | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, bugs-noreply, commit-queue, eric.carlson, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=208948 | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2020-03-17 19:01:37 PDT
Created attachment 393811 [details]
Patch
Created attachment 393812 [details]
Patch
Did you actually test it? (In reply to Konstantin Tokarev from comment #3) > Did you actually test it? I tested that it builds and that WebRTC WPT related tests pass. Check: https://wpt.fyi/results/webrtc?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned The version of WebKitGTK that its tested on the WPT CI its built for Ubuntu 18.04 in this bot https://build-webkit.igalia.com/builders/GTK%20Linux%2064-bit%20WPT%20Packaging%20%28nightly%20channel%29 And it started to fail building after r258412 Once that bot finish building correctly it uploads the built product to https://webkitgtk.org/built-products/ for later consuming on the WPT CI (taskcluster) that runs currently on Ubuntu 18.04 and runs all the WPT tests. Beyond that, I did not tested it further. If you know a specific test to try, let me know. Comment on attachment 393812 [details]
Patch
I've actually meant something like running WebRTC on some real site, but I guess passing WPT should be enough.
Comment on attachment 393812 [details] Patch Clearing flags on attachment: 393812 Committed r258624: <https://trac.webkit.org/changeset/258624> All reviewed patches have been landed. Closing bug. |