Bug 209195

Summary: Use sendWithAsyncReply for DecideDestinationWithSuggestedFilename
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, katherine_cheney, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Alex Christensen
Reported 2020-03-17 14:38:55 PDT
Use sendWithAsyncReply for DecideDestinationWithSuggestedFilename
Attachments
Patch (18.47 KB, patch)
2020-03-17 14:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.78 KB, patch)
2020-03-17 14:56 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.96 KB, patch)
2020-10-05 13:11 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-03-17 14:40:04 PDT
Created attachment 393791 [details] Patch
Alex Christensen
Comment 2 2020-03-17 14:56:29 PDT
Created attachment 393792 [details] Patch
Kate Cheney
Comment 3 2020-10-01 11:00:24 PDT
Comment on attachment 393792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393792&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2080 > + DownloadID downloadID = networkDataTask->pendingDownloadID(); could be auto downloadID? it's a bit shorter. > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2089 > + networkDataTask->setPendingDownloadLocation(destination, WTFMove(sandboxExtensionHandle), allowOverwrite == AllowOverwrite::Yes); I see the ordering of these statements changed from DownloadManager::continueDecidePendingDownloadDestination(), so now networkDataTask->setPendingDownloadLocation() won't be called if the state is canceling or completed. Was that intentional?
Alex Christensen
Comment 4 2020-10-05 13:11:40 PDT
That was unintentional, and it was the cause of the test failures.
Alex Christensen
Comment 5 2020-10-05 13:11:53 PDT
Created attachment 410545 [details] Patch
Alex Christensen
Comment 6 2020-10-05 15:29:40 PDT
Comment on attachment 410545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410545&action=review > Source/WebKit/NetworkProcess/Downloads/DownloadID.h:37 > +// FIXME: This should be an ObjectIdentifier. Note: this is being done in https://bugs.webkit.org/show_bug.cgi?id=203962
Alex Christensen
Comment 7 2020-10-05 15:38:23 PDT
http://trac.webkit.org/r268008
Radar WebKit Bug Importer
Comment 8 2020-10-05 15:39:20 PDT
<rdar://problem/69974215>
Note You need to log in before you can comment on or make changes to this bug.