Bug 209169

Summary: AXIsolatedTree removal should set all nodes to be removed on AX secondary thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-03-16 21:21:54 PDT
AXIsolatedTree removal should set all nodes to be removed on AX secondary thread.
Attachments
Patch (4.38 KB, patch)
2020-03-16 21:33 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2020-03-17 07:36 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-03-16 21:33:17 PDT
Created attachment 393726 [details] Patch
chris fleizach
Comment 2 2020-03-16 23:38:09 PDT
Comment on attachment 393726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393726&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105 > + ASSERT(isMainThread); I think this should be ASSERT(isMainThread());
Andres Gonzalez
Comment 3 2020-03-17 07:36:36 PDT
Created attachment 393754 [details] Patch
Andres Gonzalez
Comment 4 2020-03-17 07:38:55 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 393726 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393726&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:105 > > + ASSERT(isMainThread); > > I think this should be > ASSERT(isMainThread()); Corrected, thanks!
WebKit Commit Bot
Comment 5 2020-03-17 11:07:16 PDT
Comment on attachment 393754 [details] Patch Clearing flags on attachment: 393754 Committed r258560: <https://trac.webkit.org/changeset/258560>
WebKit Commit Bot
Comment 6 2020-03-17 11:07:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-17 11:08:15 PDT
<rdar://problem/60545793>
Darin Adler
Comment 8 2020-03-17 13:11:54 PDT
Comment on attachment 393754 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393754&action=review > Source/WebCore/accessibility/AccessibilityMenuList.cpp:105 > + if (is<RenderMenuList>(renderer)) > + return !downcast<RenderMenuList>(*renderer).popupIsVisible(); > + return true; I like using && in cases like this instead of an if statement.
Note You need to log in before you can comment on or make changes to this bug.