| Summary: | ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDispatchAllowedInSubtree asserts in WebKit1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sunny He <sunny_he> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, esprehn+autocc, ews-watchlist, kangil.han, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sunny He
2020-03-16 19:16:44 PDT
Created attachment 393721 [details]
Patch
Could you or Ryosuke elaborate on what these problematic design decisions are? On non-Cocoa platforms, isInWebProcess returns a constant. That is problematic. Maybe the time is come for them to implement this. (In reply to Alex Christensen from comment #2) > Could you or Ryosuke elaborate on what these problematic design decisions > are? Sync delegate callbacks. > On non-Cocoa platforms, isInWebProcess returns a constant. That is > problematic. Maybe the time is come for them to implement this. Why would it be? Nobody ships WK1 other than macOS, iOS, and Windows ports these days. Hm... looks like GTK+ build is failing for an unrelated reason? Let's re-try them. Comment on attachment 393721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393721&action=review > Source/WebCore/dom/ScriptDisallowedScope.h:27 > +#include <WebCore/RuntimeApplicationChecks.h> Oh, wait, this is not the right way to include this header. Should be: #icnlude "RuntimeApplicationChecks.h" This is probably why the build failure is happening on GTK+ etc... Created attachment 393930 [details]
Patch
Committed r258744: <https://trac.webkit.org/changeset/258744> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393930 [details]. |