Summary: | [GStreamer][WebRTC] Audio is not played from an audio element when the srcObject object has unstarted video tracks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
Component: | WebRTC | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, philipj, pnormand, sergio, tommyw, vjaquez, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=207041 | ||||||||
Attachments: |
|
Description
Lauro Moura
2020-03-16 18:12:19 PDT
I have a WIP patch... Created attachment 425092 [details]
Patch
Comment on attachment 425092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425092&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:631 > + if (track->type() == RealtimeMediaSource::Type::Video && !isVideoPlayer) Nit: I prefer to add booleans first in evaluation cause you can short-circuit some calls for the type(), etc. Created attachment 425271 [details]
Patch
Committed r275514: <https://commits.webkit.org/r275514> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425271 [details]. |