Bug 209104

Summary: [GTK] Add gtk-wk2 to EWS bubbles
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, ews-watchlist, jbedard, jean-yves.avenard, ryanhaddad, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215098
https://bugs.webkit.org/show_bug.cgi?id=234270
https://bugs.webkit.org/show_bug.cgi?id=231999
https://bugs.webkit.org/show_bug.cgi?id=234378
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2020-03-13 23:19:46 PDT
[GTK] Add gtk-wk2 to EWS bubbles
Attachments
Patch (1.83 KB, patch)
2020-03-13 23:20 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2020-08-26 04:40 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2021-12-15 19:51 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-03-13 23:20:28 PDT
Created attachment 393577 [details] Patch
Diego Pino
Comment 2 2020-08-26 04:40:29 PDT
Created attachment 407290 [details] Patch
Aakash Jain
Comment 3 2020-08-28 10:24:01 PDT
Comment on attachment 407290 [details] Patch r- since the test don't seems to be in good enough shape to be enabled here (as per the data from uat instance). Many tests are flaky/failing. Also, r265212 would need to be reverted as well in order to enable this queue.
Carlos Alberto Lopez Perez
Comment 4 2021-12-15 19:50:08 PST
On bug 231999 a new class has been added for running GTK layout tests on the EWS which can cope with a tree that is not green or that has random flakies. This has been working for several weeks and it seems to be working well. It is still a bit slow but that will improve after bug 234378 and also after I connect a few more powerful workers that I still couldn't connect (igalia10, igalia12 and igalia13). I plan to do that in the next few days. I think is time to add the bubble now. I will upload a new patch.
Carlos Alberto Lopez Perez
Comment 5 2021-12-15 19:51:45 PST
Created attachment 447319 [details] Patch
Carlos Alberto Lopez Perez
Comment 6 2021-12-15 19:53:55 PST
*** Bug 234270 has been marked as a duplicate of this bug. ***
EWS
Comment 7 2021-12-16 07:18:13 PST
Committed r287134 (245318@main): <https://commits.webkit.org/245318@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447319 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-16 07:19:20 PST
<rdar://problem/86574934>
Note You need to log in before you can comment on or make changes to this bug.