Bug 209038

Summary: Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, rmorisset, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
keith_miller: review+
patch
none
patch for landing none

Saam Barati
Reported 2020-03-12 21:04:52 PDT
...
Attachments
patch (1.51 KB, patch)
2020-03-12 21:39 PDT, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
patch (1.48 KB, patch)
2020-03-12 21:41 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (1.48 KB, patch)
2020-03-12 21:45 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-03-12 21:39:58 PDT
Created attachment 393454 [details] patch
Keith Miller
Comment 2 2020-03-12 21:40:30 PDT
Comment on attachment 393454 [details] patch r=me
Saam Barati
Comment 3 2020-03-12 21:40:42 PDT
Comment on attachment 393454 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=393454&action=review > Tools/Scripts/run-javascriptcore-tests:684 > + @testList = (); oops, will fix
Keith Miller
Comment 4 2020-03-12 21:41:07 PDT
Comment on attachment 393454 [details] patch lol whoops! r+ for realz
Saam Barati
Comment 5 2020-03-12 21:41:26 PDT
Created attachment 393455 [details] patch
Saam Barati
Comment 6 2020-03-12 21:45:29 PDT
Created attachment 393457 [details] patch for landing
WebKit Commit Bot
Comment 7 2020-03-13 00:24:40 PDT
Comment on attachment 393457 [details] patch for landing Clearing flags on attachment: 393457 Committed r258385: <https://trac.webkit.org/changeset/258385>
WebKit Commit Bot
Comment 8 2020-03-13 00:24:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-03-13 00:25:17 PDT
<rdar://problem/60407614>
Note You need to log in before you can comment on or make changes to this bug.