Bug 209038

Summary: Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
Product: WebKit Reporter: Saam Barati <sbarati>
Component: JavaScriptCoreAssignee: Saam Barati <sbarati>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, rmorisset, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
keith_miller: review+
patch
none
patch for landing none

Description Saam Barati 2020-03-12 21:04:52 PDT
...
Comment 1 Saam Barati 2020-03-12 21:39:58 PDT
Created attachment 393454 [details]
patch
Comment 2 Keith Miller 2020-03-12 21:40:30 PDT
Comment on attachment 393454 [details]
patch

r=me
Comment 3 Saam Barati 2020-03-12 21:40:42 PDT
Comment on attachment 393454 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393454&action=review

> Tools/Scripts/run-javascriptcore-tests:684
> +        @testList = ();

oops, will fix
Comment 4 Keith Miller 2020-03-12 21:41:07 PDT
Comment on attachment 393454 [details]
patch

lol whoops! r+ for realz
Comment 5 Saam Barati 2020-03-12 21:41:26 PDT
Created attachment 393455 [details]
patch
Comment 6 Saam Barati 2020-03-12 21:45:29 PDT
Created attachment 393457 [details]
patch for landing
Comment 7 WebKit Commit Bot 2020-03-13 00:24:40 PDT
Comment on attachment 393457 [details]
patch for landing

Clearing flags on attachment: 393457

Committed r258385: <https://trac.webkit.org/changeset/258385>
Comment 8 WebKit Commit Bot 2020-03-13 00:24:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-03-13 00:25:17 PDT
<rdar://problem/60407614>