Bug 209031

Summary: Correct preference handling and naming conventions in AppBound browsing preferences
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, commit-queue, katherine_cheney, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2020-03-12 17:56:05 PDT
I made a mistake in the handling of preferences related to the IsInAppBrowserPrivacyEnabled and the quirk flag, which led to some code not executing when expected. This patch does the following: 1. Uses the correct naming scheme for WebKit Internal Debug flags. 2. Adds calls 'setIsNavigatingToAppBoundDomain' in WebPageProxy::decidePolicyForNewWindowAction and WebPageProxy::decidePolicyForResponseShared, which were missed previously. 3. Updates the local quirk state in WebPage when page settings change.
Attachments
Patch (11.55 KB, patch)
2020-03-12 18:03 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (7.43 KB, patch)
2020-03-12 18:20 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-12 17:56:40 PDT
<rdar://problem/60396298>
Brent Fulgham
Comment 2 2020-03-12 18:03:03 PDT
Created attachment 393434 [details] Patch
Brent Fulgham
Comment 3 2020-03-12 18:20:07 PDT
Created attachment 393436 [details] Patch
John Wilander
Comment 4 2020-03-12 19:10:01 PDT
Comment on attachment 393436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393436&action=review > Source/WebKit/ChangeLog:10 > + and the quirk flag, which led to some code not executing when expected. Would be nice with a link to the revision or bug where the mistake was made. > Source/WebKit/ChangeLog:15 > + 'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'. I don’t know these by heart so I trust you made doubly sure this time. :)
WebKit Commit Bot
Comment 5 2020-03-12 20:09:49 PDT
Comment on attachment 393436 [details] Patch Clearing flags on attachment: 393436 Committed r258379: <https://trac.webkit.org/changeset/258379>
WebKit Commit Bot
Comment 6 2020-03-12 20:09:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.