Bug 209019

Summary: -Wredundant-move in CSSPropertyParserHelpers.cpp
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: CSSAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, mcatanzaro, menard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-03-12 13:52:30 PDT
In file included from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:56, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParser.cpp:30, from DerivedSources/WebCore/unified-sources/UnifiedSource-2f84417a-16.cpp:1: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: In function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient(WebCore::CSSParserTokenRange&, WebCore::CSSParserMode, WebCore::CSSGradientRepeat)’: DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: warning: redundant move in return statement [-Wredundant-move] 495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’ 1176 | return WTFMove(result); | ^~~~~~~ DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: note: remove ‘std::move’ call 495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’ 1176 | return WTFMove(result); | ^~~~~~~
Attachments
Patch (1.53 KB, patch)
2020-03-12 13:54 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-03-12 13:54:27 PDT
Created attachment 393411 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-13 03:31:50 PDT
Comment on attachment 393411 [details] Patch Clearing flags on attachment: 393411 Committed r258392: <https://trac.webkit.org/changeset/258392>
WebKit Commit Bot
Comment 3 2020-03-13 03:31:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-13 03:32:15 PDT
<rdar://problem/60412242>
Note You need to log in before you can comment on or make changes to this bug.