Bug 208996

Summary: Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2020-03-12 07:53:55 PDT
Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread.
Comment 1 Andres Gonzalez 2020-03-12 07:56:57 PDT
Created attachment 393376 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-12 12:07:00 PDT
Comment on attachment 393376 [details]
Patch

Clearing flags on attachment: 393376

Committed r258349: <https://trac.webkit.org/changeset/258349>
Comment 3 WebKit Commit Bot 2020-03-12 12:07:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-12 12:07:17 PDT
<rdar://problem/60381174>
Comment 5 Darin Adler 2020-03-12 12:28:13 PDT
Comment on attachment 393376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393376&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830
> +        return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> {

Maybe we can write this more elegantly using the retainPtr helper function?

    [protectedSelf = retainPtr(self)]
Comment 6 Andres Gonzalez 2020-03-12 13:26:58 PDT
(In reply to Darin Adler from comment #5)
> Comment on attachment 393376 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=393376&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830
> > +        return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> {
> 
> Maybe we can write this more elegantly using the retainPtr helper function?
> 
>     [protectedSelf = retainPtr(self)]

Agree, I'll make a separate change with a sweep through all the instances of this construct. Thanks.