Bug 20899

Summary: should not expose <table> as AXTable if there is an ARIA role
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
if <table> has an ARIA role, then it should appear as an AXTable bdakin: review+

chris fleizach
Reported 2008-09-17 10:28:50 PDT
if a <Table> object has an ARIA role of something other than table, it should not be exposed as an AXTable
Attachments
if <table> has an ARIA role, then it should appear as an AXTable (43.37 KB, patch)
2008-09-18 15:02 PDT, chris fleizach 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2008-09-18 15:02:19 PDT
Created attachment 23540 [details] if <table> has an ARIA role, then it should appear as an AXTable
Sam Weinig
Comment 2 2008-09-18 15:36:10 PDT
Comment on attachment 23540 [details] if <table> has an ARIA role, then it should appear as an AXTable - if (!isDataTable()) { - AccessibilityRenderObject::addChildren(); - return; - } + if (!isDataTable()) + return AccessibilityRenderObject::addChildren(); We try and not return an function with a void return value, unless it is necessary for templates to work.
chris fleizach
Comment 3 2008-09-18 15:38:34 PDT
will change. figured i could save 2 lines of code that way
Beth Dakin
Comment 4 2008-09-18 15:48:36 PDT
Comment on attachment 23540 [details] if <table> has an ARIA role, then it should appear as an AXTable Looks good!
Note You need to log in before you can comment on or make changes to this bug.