Bug 20899

Summary:

should not expose <table> as AXTable if there is an ARIA role

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
if <table> has an ARIA role, then it should appear as an AXTable	bdakin: review+

Description chris fleizach 2008-09-17 10:28:50 PDT

if a <Table> object has an ARIA role of something other than table, it should not be exposed as an AXTable

Comment 1 chris fleizach 2008-09-18 15:02:19 PDT

Created attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable

Comment 2 Sam Weinig 2008-09-18 15:36:10 PDT

Comment on attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable

-    if (!isDataTable()) {
-        AccessibilityRenderObject::addChildren();
-        return;
-    }
+    if (!isDataTable())
+        return AccessibilityRenderObject::addChildren();
We try and not return an function with a void return value, unless it is necessary for templates to work.

Comment 3 chris fleizach 2008-09-18 15:38:34 PDT

will change. figured i could save 2 lines of code that way

Comment 4 Beth Dakin 2008-09-18 15:48:36 PDT

Comment on attachment 23540 [details]
if <table> has an ARIA role, then it should appear as an AXTable

Looks good!