Bug 208968

Summary: Non-unified build fixes early March 2020 edition Take 2
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, ews-watchlist, glenn, jer.noble, mifenton, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Don Olmstead 2020-03-11 19:18:14 PDT
This is the song that doesn't end.
Yes, it goes on and on my friend.
Some people started singing it, not knowing what it was,
And they'll continue singing it forever just because...
Comment 1 Don Olmstead 2020-03-11 19:25:22 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-03-11 19:28:49 PDT
Created attachment 393328 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-11 20:19:13 PDT
Comment on attachment 393328 [details]
Patch

Clearing flags on attachment: 393328

Committed r258310: <https://trac.webkit.org/changeset/258310>
Comment 4 WebKit Commit Bot 2020-03-11 20:19:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-11 20:20:18 PDT
<rdar://problem/60354166>
Comment 6 Darin Adler 2020-03-15 12:18:57 PDT
Comment on attachment 393328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393328&action=review

> Source/WebCore/editing/TextIterator.h:30
> +#include "SimpleRange.h"

Oh, no, really!? We definitely don’t want TextIterator.h to include SimpleRange.h.

It’s the .cpp files that need it that should be including it. I know there could be a lot of them, but please don’t add this to the header like this.