Summary: | Non-unified build fixes early March 2020 edition Take 2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, eric.carlson, ews-watchlist, glenn, jer.noble, mifenton, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Don Olmstead
2020-03-11 19:18:14 PDT
Created attachment 393327 [details]
Patch
Created attachment 393328 [details]
Patch
Comment on attachment 393328 [details] Patch Clearing flags on attachment: 393328 Committed r258310: <https://trac.webkit.org/changeset/258310> All reviewed patches have been landed. Closing bug. Comment on attachment 393328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393328&action=review > Source/WebCore/editing/TextIterator.h:30 > +#include "SimpleRange.h" Oh, no, really!? We definitely don’t want TextIterator.h to include SimpleRange.h. It’s the .cpp files that need it that should be including it. I know there could be a lot of them, but please don’t add this to the header like this. |