Bug 208965

Summary: [GPUP] Add entry points for non-Cocoa ports
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206697    
Attachments:
Description Flags
Patch
mcatanzaro: review+
Patch none

Don Olmstead
Reported 2020-03-11 18:16:50 PDT
Add an entry point for non-Cocoa ports.
Attachments
Patch (15.36 KB, patch)
2020-03-11 18:52 PDT, Don Olmstead 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch (15.32 KB, patch)
2020-03-11 19:06 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-03-11 18:52:41 PDT
Created attachment 393325 [details] Patch
Michael Catanzaro
Comment 2 2020-03-11 19:04:00 PDT
Comment on attachment 393325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393325&action=review Entry points are better than no entry points! > Source/WebKit/GPUProcess/EntryPoint/win/GPUProcessMain.cpp:30 > +#include <stdio.h> > +#include <windows.h> Surely you don't need these.
Don Olmstead
Comment 3 2020-03-11 19:06:33 PDT
Created attachment 393326 [details] Patch
WebKit Commit Bot
Comment 4 2020-03-11 19:55:50 PDT
Comment on attachment 393326 [details] Patch Clearing flags on attachment: 393326 Committed r258309: <https://trac.webkit.org/changeset/258309>
WebKit Commit Bot
Comment 5 2020-03-11 19:55:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-03-11 19:56:16 PDT
<rdar://problem/60353614>
Note You need to log in before you can comment on or make changes to this bug.