Bug 208958

Summary: [GPUP] Add special handling of MediaTime within message generator
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206697    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2020-03-11 17:06:33 PDT
GPU Process added MediaTime to messages.in files. The messages.py script wasn't updated for special handling of this. Pretty sure the only reason this works is because of a .cpp file being included in a unified build. For non-unified builds the following happens In file included from ../../Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:35: WebKit/DerivedSources\MediaPlayerPrivateRemoteMessages.h:546:75: error: unknown type name 'MediaTime' typedef std::tuple<const WebKit::TrackPrivateRemoteIdentifier&, const MediaTime&, const MediaTime&, const IPC::DataReference&> Arguments;
Attachments
Patch (2.29 KB, patch)
2020-03-11 17:20 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-03-11 17:20:38 PDT
Created attachment 393313 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-11 18:35:31 PDT
Comment on attachment 393313 [details] Patch Clearing flags on attachment: 393313 Committed r258305: <https://trac.webkit.org/changeset/258305>
WebKit Commit Bot
Comment 3 2020-03-11 18:35:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-11 18:36:17 PDT
<rdar://problem/60351441>
Note You need to log in before you can comment on or make changes to this bug.