Bug 208954

Summary: Make flatpack import for run-webkit-tests only happen on linux systems
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Tools / TestsAssignee: Matt Lewis <jlewis3>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, jbedard, mcatanzaro, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Matt Lewis
Reported 2020-03-11 16:27:31 PDT
import Flatpack was added to run-webkit-test as a required import and means that we can't run the script without it on any other platforms, even when not needed. We should be able to run the script and determine at call time if we need the import.
Attachments
Patch (2.26 KB, patch)
2020-03-11 16:57 PDT, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (1.96 KB, patch)
2020-03-12 10:03 PDT, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-11 16:27:50 PDT
<rdar://problem/60346729>
Matt Lewis
Comment 2 2020-03-11 16:57:18 PDT
Created attachment 393308 [details] Patch
Jonathan Bedard
Comment 3 2020-03-11 17:17:00 PDT
Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review This looks correct to be, but I'd like the folks more familiar with how we actually use flatpak. Another alternative approach would be to conditionalize on if flatpak can be found in the provided directory. > Tools/Scripts/run-webkit-tests:16 > +# * Neither the Google name nor the names of its No reason to make this change
Philippe Normand
Comment 4 2020-03-12 02:16:53 PDT
Comment on attachment 393308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review > Tools/Scripts/run-webkit-tests:39 > +if sys.platform.startswith('Linux'): lower-case linux
Matt Lewis
Comment 5 2020-03-12 10:03:43 PDT
Created attachment 393386 [details] Patch
WebKit Commit Bot
Comment 6 2020-03-12 12:01:56 PDT
Comment on attachment 393386 [details] Patch Clearing flags on attachment: 393386 Committed r258347: <https://trac.webkit.org/changeset/258347>
WebKit Commit Bot
Comment 7 2020-03-12 12:01:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.