Bug 208938

Summary: commit-queue should skip testing if patch already passed tests on mac-wk2 queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208941
Bug Depends on: 208940, 209342    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Aakash Jain
Reported 2020-03-11 12:48:34 PDT
commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue. Both commit-queue and mac-wk2 queue run same tests (WK2 layout-tests in release mode).
Attachments
Patch (9.20 KB, patch)
2020-03-20 13:00 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (10.20 KB, patch)
2020-03-20 14:02 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.06 KB, patch)
2020-03-20 14:13 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2020-03-11 12:56:45 PDT
IIRC the old queue would re-test if substantial amount of time passed since the EWS run. We had a lot of discussion about stricter logic in the past (e.g. don't land until all EWSes were done), but no concrete changes planned.
Aakash Jain
Comment 2 2020-03-20 13:00:00 PDT
Created attachment 394113 [details] Patch
Aakash Jain
Comment 3 2020-03-20 13:00:19 PDT
Comment on attachment 394113 [details] Patch Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1660
Aakash Jain
Comment 4 2020-03-20 13:22:25 PDT
(In reply to Alexey Proskuryakov from comment #1) > IIRC the old queue would re-test if substantial amount of time passed since the EWS run. I don't see any logic regarding time limit for re-testing in old EWS code https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L434 (and the code hasn't changed in a long time)
Aakash Jain
Comment 5 2020-03-20 14:02:09 PDT
Created attachment 394122 [details] Patch
Aakash Jain
Comment 6 2020-03-20 14:13:18 PDT
Created attachment 394125 [details] Patch for landing
EWS
Comment 7 2020-03-20 14:38:42 PDT
Committed r258790: <https://trac.webkit.org/changeset/258790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394125 [details].
Radar WebKit Bug Importer
Comment 8 2020-03-20 14:39:13 PDT
<rdar://problem/60705157>
Aakash Jain
Comment 9 2020-03-21 02:51:09 PDT
Updated bug title to reflect that commit-queue only skips testing. It never skips building. Although since the builds are incremental, they are usually fast. Also deployed on production server.
Note You need to log in before you can comment on or make changes to this bug.