Bug 208897

Summary: Non-unified build fixes early March 2020 edition
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, cmarcelo, commit-queue, darin, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, japhet, jer.noble, kangil.han, luiz, mifenton, philipj, sergio, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2020-03-10 17:02:51 PDT
Letting the days go by (same as it ever was) Same as it ever was (same as it ever was) Letting the days go by (same as it ever was) Same as it ever was
Attachments
Patch (4.54 KB, patch)
2020-03-10 17:28 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-03-10 17:28:54 PDT
Created attachment 393188 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-10 19:41:04 PDT
Comment on attachment 393188 [details] Patch Clearing flags on attachment: 393188 Committed r258248: <https://trac.webkit.org/changeset/258248>
WebKit Commit Bot
Comment 3 2020-03-10 19:41:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-10 19:42:19 PDT
<rdar://problem/60304002>
Darin Adler
Comment 5 2020-03-15 11:59:42 PDT
Comment on attachment 393188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393188&action=review > Source/WebCore/dom/BoundaryPoint.h:28 > +#include "Node.h" it’s a pretty big change to BoundaryPoint.h, causing to pull in all of Node.h. It obviates the need for BoundaryPoint.cpp entirely since that was the only thing different driving us to not have all functions be inlines. How did you determine this was needed, and couldn’t be fixed by adding includes elsewhere?
Note You need to log in before you can comment on or make changes to this bug.