Bug 208834

Summary: [macOS] Notification observer is not removed
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Per Arne Vollan
Reported 2020-03-09 15:01:13 PDT
The Accessibility notification observer is not being removed on macOS.
Attachments
Patch (8.71 KB, patch)
2020-03-09 15:09 PDT, Per Arne Vollan 		thorton: review+
DetailsFormatted DiffDiff
Patch (8.71 KB, patch)
2020-03-09 15:25 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-03-09 15:01:38 PDT
rdar://problem/60238852
Per Arne Vollan
Comment 2 2020-03-09 15:09:31 PDT
Created attachment 393079 [details] Patch
Per Arne Vollan
Comment 3 2020-03-09 15:25:19 PDT
Created attachment 393084 [details] Patch
Per Arne Vollan
Comment 4 2020-03-09 15:25:46 PDT
Thanks for reviewing!
Per Arne Vollan
Comment 5 2020-03-09 16:48:58 PDT
Committed r258174: <https://trac.webkit.org/changeset/258174/webkit>
Darin Adler
Comment 6 2020-03-17 15:52:32 PDT
Comment on attachment 393079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393079&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:693 > #endif > #endif // PLATFORM(IOS) > #endif // !PLATFORM(IOS_FAMILY) I think we’d do better at understanding the conditionals here if this wasn’t nested.
Per Arne Vollan
Comment 7 2020-03-17 16:05:46 PDT
(In reply to Darin Adler from comment #6) > Comment on attachment 393079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393079&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:693 > > #endif > > #endif // PLATFORM(IOS) > > #endif // !PLATFORM(IOS_FAMILY) > > I think we’d do better at understanding the conditionals here if this wasn’t > nested. That's a good point, it can be a bit confusing. Thanks for reviewing!
Note You need to log in before you can comment on or make changes to this bug.