Summary: | Remove obsolete feature flags | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||
Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, annulen, benjamin, cdumez, cmarcelo, commit-queue, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jbedard, keith_miller, kondapallykalyan, mark.lam, mifenton, mmaxfield, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Don Olmstead
2020-03-09 13:42:30 PDT
Created attachment 393069 [details]
WIP Patch
Created attachment 393076 [details]
WIP Patch
(In reply to Don Olmstead from comment #0) > Remove any obsolete ENABLE flags from the build system. Find any misused > ENABLE flags. Could we make the bug title a bit more descriptive? Something like 'Remove obsolete feature flags'. Cleanup feature defines could refer to a few different things. Created attachment 393082 [details]
Patch
Created attachment 393095 [details]
Patch
Don't try and sort anything in FeatureDefines.xcconfig.
Comment on attachment 393095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393095&action=review > Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:-314 > -ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); This is very much still used (In reply to Alex Christensen from comment #6) > Comment on attachment 393095 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393095&action=review > > > Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:-314 > > -ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); > > This is very much still used https://trac.webkit.org/changeset/258148/webkit Created attachment 393099 [details]
Patch
Reuploading to make sure the changelog is clear about ENABLE_POINTER_EVENTS being removed in a patch today.
Comment on attachment 393099 [details] Patch Clearing flags on attachment: 393099 Committed r258181: <https://trac.webkit.org/changeset/258181> All reviewed patches have been landed. Closing bug. Comment on attachment 393099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393099&action=review > Source/cmake/WebKitFeatures.cmake:228 > + WEBKIT_OPTION_DEFINE(ENABLE_WIRELESS_PLAYBACK_TARGET "Togle wireless playback target support" PRIVATE OFF) "Togle"! Comment on attachment 393099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393099&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:424 > -#if ENABLE(WIRELESS_TARGET_PLAYBACK) > +#if ENABLE(WIRELESS_PLAYBACK_TARGET) > configuration->_allowsAirPlayForMediaPlayback = self->_allowsAirPlayForMediaPlayback; > #endif Love that you fixed this. Puzzled that there is no test coverage! (In reply to Darin Adler from comment #13) > Comment on attachment 393099 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393099&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:424 > > -#if ENABLE(WIRELESS_TARGET_PLAYBACK) > > +#if ENABLE(WIRELESS_PLAYBACK_TARGET) > > configuration->_allowsAirPlayForMediaPlayback = self->_allowsAirPlayForMediaPlayback; > > #endif > > Love that you fixed this. Puzzled that there is no test coverage! Yea there were a few I was surprised to find. Thank the script at https://bugs.webkit.org/show_bug.cgi?id=208726 which found these issues. Hoping to get it integrated tomorrow and also start generating some of these things. |