Bug 208816

Summary: Remove sync IPC when creating a remote capture source
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-03-09 08:53:20 PDT
Remove sync IPC when creating a remote capture source
Attachments
Patch (23.35 KB, patch)
2020-03-09 09:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (23.35 KB, patch)
2020-03-09 09:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (23.37 KB, patch)
2020-03-09 09:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (23.64 KB, patch)
2020-03-09 09:12 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.74 KB, patch)
2020-03-10 05:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-03-09 09:03:37 PDT
Created attachment 393040 [details] Patch
youenn fablet
Comment 2 2020-03-09 09:04:32 PDT
Created attachment 393041 [details] Patch
youenn fablet
Comment 3 2020-03-09 09:07:22 PDT
Created attachment 393042 [details] Patch
youenn fablet
Comment 4 2020-03-09 09:12:12 PDT
Created attachment 393043 [details] Patch
Eric Carlson
Comment 5 2020-03-09 11:11:15 PDT
Comment on attachment 393043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393043&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98 > + CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable { Shouldn't this be called 'waitForVideoSource'? Why do you WTFMove() videoSource but not audioSource?
youenn fablet
Comment 6 2020-03-10 04:45:46 PDT
(In reply to Eric Carlson from comment #5) > Comment on attachment 393043 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393043&action=review > > > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98 > > + CompletionHandler<void(String&&)> waitForAudioSource = [audioSource, videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler = WTFMove(completionHandler)](auto&& errorMessage) mutable { > > Shouldn't this be called 'waitForVideoSource'? I will rename it to onceAudioSourceReady. > Why do you WTFMove() videoSource but not audioSource? We are using audioSource below so cannot do that.
youenn fablet
Comment 7 2020-03-10 05:04:53 PDT
Created attachment 393136 [details] Patch for landing
WebKit Commit Bot
Comment 8 2020-03-10 05:53:45 PDT
Comment on attachment 393136 [details] Patch for landing Clearing flags on attachment: 393136 Committed r258201: <https://trac.webkit.org/changeset/258201>
WebKit Commit Bot
Comment 9 2020-03-10 05:53:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-03-10 05:54:17 PDT
<rdar://problem/60270112>
Note You need to log in before you can comment on or make changes to this bug.