Bug 208787

Summary:

Build Fix

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Megan Gardner 2020-03-08 12:18:41 PDT

Build Fix

Comment 1 Megan Gardner 2020-03-08 12:20:14 PDT

Created attachment 392969 [details]
Patch

Comment 2 Tim Horton 2020-03-08 12:21:38 PDT

Comment on attachment 392969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392969&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719
> +#if USE(UICONTEXTMENU) && HAVE(LINKPREVIEW)

HAVE(LINKPREVIEW) isn't a thing, so you've killed your feature.

Comment 3 Megan Gardner 2020-03-08 12:32:12 PDT

Created attachment 392973 [details]
Patch

Comment 4 Tim Horton 2020-03-08 12:41:40 PDT

Comment on attachment 392973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392973&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719
> -#if USE(UICONTEXTMENU)
> +#if USE(UICONTEXTMENU) && HAVE(LINK_PREVIEW)

Pretty sure you want ENABLE(DATA_DETECTION) instead of HAVE(LINK_PREVIEW)

Comment 5 Megan Gardner 2020-03-08 12:41:42 PDT

Created attachment 392977 [details]
Patch

Comment 6 Megan Gardner 2020-03-08 13:03:32 PDT

Committed r258110: <https://trac.webkit.org/changeset/258110>

Comment 7 Radar WebKit Bug Importer 2020-03-08 13:04:16 PDT

<rdar://problem/60203670>