Bug 208787

Summary: Build Fix
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2020-03-08 12:18:41 PDT
Build Fix
Attachments
Patch (3.98 KB, patch)
2020-03-08 12:20 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.98 KB, patch)
2020-03-08 12:32 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-03-08 12:41 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-03-08 12:20:14 PDT
Created attachment 392969 [details] Patch
Tim Horton
Comment 2 2020-03-08 12:21:38 PDT
Comment on attachment 392969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392969&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719 > +#if USE(UICONTEXTMENU) && HAVE(LINKPREVIEW) HAVE(LINKPREVIEW) isn't a thing, so you've killed your feature.
Megan Gardner
Comment 3 2020-03-08 12:32:12 PDT
Created attachment 392973 [details] Patch
Tim Horton
Comment 4 2020-03-08 12:41:40 PDT
Comment on attachment 392973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392973&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719 > -#if USE(UICONTEXTMENU) > +#if USE(UICONTEXTMENU) && HAVE(LINK_PREVIEW) Pretty sure you want ENABLE(DATA_DETECTION) instead of HAVE(LINK_PREVIEW)
Megan Gardner
Comment 5 2020-03-08 12:41:42 PDT
Created attachment 392977 [details] Patch
Megan Gardner
Comment 6 2020-03-08 13:03:32 PDT
Committed r258110: <https://trac.webkit.org/changeset/258110>
Radar WebKit Bug Importer
Comment 7 2020-03-08 13:04:16 PDT
<rdar://problem/60203670>
Note You need to log in before you can comment on or make changes to this bug.