Bug 208765

Summary: [GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, peng.liu6, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2020-03-07 09:59:46 PST
[GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type
Attachments
Patch (2.45 KB, patch)
2020-03-07 10:01 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-03-07 10:01:58 PST
Created attachment 392863 [details] Patch
Darin Adler
Comment 2 2020-03-07 12:41:42 PST
Comment on attachment 392863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392863&action=review > Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:220 > + static std::once_flag onceFlag; > + std::call_once(onceFlag, [] { For any one code change, seems OK to use std::call_once to avoid calling multiple times, even when the code isn’t safe to use from multiple threads. But since std::call_once is the thread-safe, more-expensive way of doing it, it might be slight overkill. Not sure what our overall project strategy should be for such things.
WebKit Commit Bot
Comment 3 2020-03-07 20:38:27 PST
Comment on attachment 392863 [details] Patch Clearing flags on attachment: 392863 Committed r258099: <https://trac.webkit.org/changeset/258099>
WebKit Commit Bot
Comment 4 2020-03-07 20:38:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-07 20:39:19 PST
<rdar://problem/60195875>
Note You need to log in before you can comment on or make changes to this bug.