Bug 208753 – [WPE] some tests are flaky crashing in HeadlessViewBackend::displayBuffer

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Lauro Moura]

From build 17196/r258024:

* http/tests/referrer-policy-anchor/no-referrer-when-downgrade/cross-origin-http.https.html
* http/tests/referrer-policy-anchor/no-referrer/cross-origin-http-http.html
* http/tests/referrer-policy-anchor/same-origin/cross-origin-http.https.html
* http/tests/referrer-policy-anchor/strict-origin-when-cross-origin/cross-origin-http.https.html
* http/tests/referrer-policy-anchor/strict-origin/cross-origin-http.https.html
* http/tests/referrer-policy-anchor/unsafe-url/cross-origin-http.https.html

[Lauro Moura]

Flaky since introduced (some more, some a bit less).

Same stack in all of them:

Thread 1 (Thread 0x7fc8915e15c0 (LWP 4011)):
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007fc8929ad535 in __GI_abort () at abort.c:79
#2  0x00005597ab8a870b in WPEToolingBackends::HeadlessViewBackend::displayBuffer(wpe_fdo_egl_exported_image*) [clone .cold.7] ()
#3  0x00007fc8972a84d8 in (anonymous namespace)::ClientBundleEGL::exportImage(wpe_fdo_egl_exported_image*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#4  0x00007fc8972a8361 in (anonymous namespace)::ClientBundleEGL::exportBuffer(linux_dmabuf_buffer const*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#5  0x00007fc89729ffac in ViewBackend::exportLinuxDmabuf(linux_dmabuf_buffer const*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#6  0x00007fc8972a0c7c in WS::{lambda(wl_client*, wl_resource*)#10}::operator()(wl_client*, wl_resource*) const () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#7  0x00007fc8972a0d08 in WS::{lambda(wl_client*, wl_resource*)#10}::_FUN(wl_client*, wl_resource*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#8  0x00007fc891cb4162 in ffi_call_unix64 () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libffi.so.5
#9  0x00007fc891cb39f5 in ffi_call (cif=<optimized out>, fn=<optimized out>, rvalue=<optimized out>, avalue=<optimized out>) at /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Source/libffi-3.0.10/src/x86/ffi64.c:486
#10 0x00007fc892e91b2d in ?? () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#11 0x00007fc892e8e5a9 in ?? () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#12 0x00007fc892e8fb72 in wl_event_loop_dispatch () from /usr/lib/x86_64-linux-gnu/libwayland-server.so.0
#13 0x00007fc8972a082d in WS::ServerSource::{lambda(_GSource*, int (*)(void*), void*)#3}::operator()(_GSource*, int (*)(void*), void*) const () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#14 0x00007fc8972a0894 in WS::ServerSource::{lambda(_GSource*, int (*)(void*), void*)#3}::_FUN(_GSource*, int (*)(void*), void*) () from /home/buildbot/wpe/wpe-linux-64-release-tests/build/WebKitBuild/DependenciesWPE/Root/lib/libWPEBackend-fdo-1.0.so.1
#15 0x00007fc89736780e in g_main_dispatch (context=0x5597abc67a80) at ../../Source/glib-2.58.1/glib/gmain.c:3182
#16 g_main_context_dispatch (context=context@entry=0x5597abc67a80) at ../../Source/glib-2.58.1/glib/gmain.c:3847
#17 0x00007fc897367a78 in g_main_context_iterate (context=0x5597abc67a80, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../Source/glib-2.58.1/glib/gmain.c:3920
#18 0x00007fc897367d62 in g_main_loop_run (loop=0x5597abc68c80) at ../../Source/glib-2.58.1/glib/gmain.c:4116
#19 0x00007fc89c058ca0 in WTF::RunLoop::run() () from /home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib/libWPEWebKit-1.0.so.3
#20 0x00005597ab8de762 in WTR::TestController::platformRunUntil(bool&, WTF::Seconds) ()
#21 0x00005597ab8c98d1 in WTR::TestInvocation::invoke() ()
#22 0x00005597ab8ba5fd in WTR::TestController::runTest(char const*) ()
#23 0x00005597ab8bad05 in WTR::TestController::runTestingServerLoop() ()
#24 0x00005597ab8bb0a8 in WTR::TestController::TestController(int, char const**) ()
#25 0x00005597ab8a8755 in main ()

STDERR: 
STDERR: warning: core file may not match specified executable file.
STDERR: 50	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
STDERR: EGLDisplay Initialization failed: EGL_NOT_INITIALIZED

[Lauro Moura]

This seems to be more graphics-related than a referrer-policy-anchor specific issue.

It appeared too in the following tests from the same build:

* http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority.html
* http/tests/adClickAttribution/second-conversion-with-higher-priority.html
* http/tests/cache/partitioned-cache.html

And also for the following from bug 202732:

* http/tests/adClickAttribution/expired-attributions-removed.html
* http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html
* http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html
* http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html

Running the first two of this last block seemed enough to crash at least one of the tests almost half of the time here:

* 20 runs: 9 crashes in the second test

With run-singly:

* 20 runs: No crashes.

Maybe something in the headless backend is not being cleared up right between test runs?

[Lauro Moura]

Few more crashing tests from last builds:

* http/tests/cache/partitioned-cache-iframe.html
* http/tests/referrer-policy-anchor/no-referrer/cross-origin-http.https.html
* http/tests/cookies/same-site/popup-cross-site-post.html
* http/tests/referrer-policy-anchor/origin-when-cross-origin/cross-origin-http-http.html
* http/tests/referrer-policy-anchor/origin/cross-origin-http.https.html

[Diego Pino]

http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html is passing after r259705.

Update test expectations in r260563.

[Zan Dobersek]

Consistently passing now, probably due to some fixes in WPEBackend-fdo.