Bug 208705

Summary: JSDOMIterator classes should be in IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: DOMAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, jsbell, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Yusuke Suzuki
Reported 2020-03-06 03:52:01 PST
IIUC, this is the last thing we should put it into IsoSubspace in WebCore side.
Attachments
Patch (111.37 KB, patch)
2020-03-06 05:02 PST, Yusuke Suzuki 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-03-06 03:53:47 PST
We should collect iterator classes in preprocess-idls.pl. And putting all of them into DOMIsoSubspaces class. And instead of using typedef-ed JSDOMIterator directly, we should create a class which is inheriting JSDOMIteratorImpl<Class>, and offering subspaceFor implementation. And another thing we should do is putting `void subspaceFor` implementation for JSDOMObject to ensure that any derived classes of JSDOMObject should not get allocated from non IsoSubspace.
Yusuke Suzuki
Comment 2 2020-03-06 05:02:14 PST
Created attachment 392707 [details] Patch
Yusuke Suzuki
Comment 3 2020-03-06 15:03:22 PST
Committed r258032: <https://trac.webkit.org/changeset/258032>
Radar WebKit Bug Importer
Comment 4 2020-03-06 15:04:16 PST
<rdar://problem/60172271>
Note You need to log in before you can comment on or make changes to this bug.