Summary: | JSDOMIterator classes should be in IsoSubspace | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | DOM | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, beidson, cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, jsbell, philipj, sam, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-03-06 03:52:01 PST
We should collect iterator classes in preprocess-idls.pl. And putting all of them into DOMIsoSubspaces class. And instead of using typedef-ed JSDOMIterator directly, we should create a class which is inheriting JSDOMIteratorImpl<Class>, and offering subspaceFor implementation. And another thing we should do is putting `void subspaceFor` implementation for JSDOMObject to ensure that any derived classes of JSDOMObject should not get allocated from non IsoSubspace. Created attachment 392707 [details]
Patch
Committed r258032: <https://trac.webkit.org/changeset/258032> |