Bug 208693

Summary: [webkitpy] Fix executive on Windows to run wpt server correctly
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, cdumez, commit-queue, darin, ews-watchlist, fujii.hironori, glenn, japhet, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH
none
PATCH none

Basuke Suzuki
Reported 2020-03-05 21:05:06 PST
Caused by typo.
Attachments
PATCH (2.23 KB, patch)
2020-03-06 16:10 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (3.69 KB, patch)
2020-03-06 16:21 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (3.69 KB, patch)
2020-03-06 16:53 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2020-03-06 16:10:44 PST
Created attachment 392796 [details] PATCH
Fujii Hironori
Comment 2 2020-03-06 16:18:25 PST
Comment on attachment 392796 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392796&action=review > Source/WebCore/loader/cache/CachedImage.cpp:569 > + } Whats this?
Basuke Suzuki
Comment 3 2020-03-06 16:21:04 PST
Created attachment 392798 [details] PATCH
Basuke Suzuki
Comment 4 2020-03-06 16:23:32 PST
Sorry, I submitted a wrong file X( New one is good to go.
Jonathan Bedard
Comment 5 2020-03-06 16:33:15 PST
Comment on attachment 392798 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392798&action=review > Tools/Scripts/webkitpy/common/system/executive.py:324 > + def _windows_killCommand(self): If this is an instance function, we shouldn't need the 'self._is_native_win' in kill_all. Otherwise it should be a staticmethod or a class variable (Like what we did with PIPE and STDOUT)
Basuke Suzuki
Comment 6 2020-03-06 16:53:28 PST
Created attachment 392812 [details] PATCH
Jonathan Bedard
Comment 7 2020-03-06 16:56:25 PST
Comment on attachment 392812 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review > Tools/Scripts/webkitpy/common/system/executive.py:326 > + return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe") Do we actually need os.sep here? I would expect os.path.join(...) to do that for you.
Basuke Suzuki
Comment 8 2020-03-06 17:02:07 PST
Comment on attachment 392812 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review >> Tools/Scripts/webkitpy/common/system/executive.py:326 >> + return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe") > > Do we actually need os.sep here? I would expect os.path.join(...) to do that for you. Well that part is copied from existing code, which is working. So I left untouched that.
WebKit Commit Bot
Comment 9 2020-03-06 17:53:56 PST
Comment on attachment 392812 [details] PATCH Clearing flags on attachment: 392812 Committed r258045: <https://trac.webkit.org/changeset/258045>
WebKit Commit Bot
Comment 10 2020-03-06 17:53:58 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-03-06 17:54:17 PST
<rdar://problem/60178285>
Note You need to log in before you can comment on or make changes to this bug.