| Summary: | Implementation of AccessibilitySupport AXSIsolatedTreeMode. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aboxhall, annulen, apinheiro, cdumez, cfleizach, commit-queue, dino, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, ryuan.choi, saagar, samuel_white, sergio, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Andres Gonzalez
2020-03-05 20:41:49 PST
Created attachment 392668 [details]
Patch
Created attachment 392714 [details]
Patch
Created attachment 392734 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 392734 [details]: media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 392734 [details] Patch Clearing flags on attachment: 392734 Committed r258047: <https://trac.webkit.org/changeset/258047> All reviewed patches have been landed. Closing bug. This change was rolled out due to incompatibility with SDK. Created attachment 392965 [details]
Patch
Fixes incompatibility with SDK by softlinking with AccessibilitySupport. Created attachment 392975 [details]
Patch
Created attachment 392980 [details]
Patch
Comment on attachment 392980 [details] Patch Clearing flags on attachment: 392980 Committed r258115: <https://trac.webkit.org/changeset/258115> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #14) > All reviewed patches have been landed. Closing bug. I have been having trouble building since this change: Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85: error: unknown type name 'AXSIsolatedTreeMode' (In reply to Chris Dumez from comment #15) > (In reply to WebKit Commit Bot from comment #14) > > All reviewed patches have been landed. Closing bug. > > I have been having trouble building since this change: > Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85: > error: unknown type name 'AXSIsolatedTreeMode' Same here. I don't see AXSIsolatedTreeMode defined anywhere in current or future versions of macOS. (In reply to Dean Jackson from comment #16) > (In reply to Chris Dumez from comment #15) > > (In reply to WebKit Commit Bot from comment #14) > > > All reviewed patches have been landed. Closing bug. > > > > I have been having trouble building since this change: > > Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSoftLink.h:36:85: > > error: unknown type name 'AXSIsolatedTreeMode' > > Same here. I don't see AXSIsolatedTreeMode defined anywhere in current or > future versions of macOS. You would need a recent version of SDK. In the future if a change requires an SDK that is newer than a couple of days old, could you email our internal list to let people know? (or, even better, stage it so that people don't need to upgrade). Hi, sorry to resurrect a months-old bug, but I'm seeing a build failure suspiciously similar to the one described here when using the public 10.16 SDK. If AXSIsolatedTreeMode is SPI (it looks like it is?) would you mind adding a stub or polyfill of some sort so that I can build WebKit without it? |