Bug 208663

Summary: [First paint] Fixed sized SVG content should taken into account when computing VNE status
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2020-03-05 13:11:06 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-03-05 13:11:30 PST 
<rdar://problem/60096896>
Comment 2 zalan 2020-03-05 13:16:33 PST 
Created attachment 392613 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-03-05 13:48:34 PST 
Comment on attachment 392613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392613&action=review

> Source/WebCore/ChangeLog:9
> +        Let's add fixed sized SVG to the list if content we track as VNE pixel count.

if -> of

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:944
> +        // SVG content tends to have a fixed size construct.

Maybe more words about how we know this is wrong in some ways.
Comment 4 zalan 2020-03-05 14:57:19 PST 
Created attachment 392630 [details]
Patch
Comment 5 zalan 2020-03-05 14:58:48 PST 
Created attachment 392631 [details]
Patch
Comment 6 WebKit Commit Bot 2020-03-05 15:44:03 PST 
Comment on attachment 392631 [details]
Patch

Clearing flags on attachment: 392631

Committed r257952: <https://trac.webkit.org/changeset/257952>
Comment 7 WebKit Commit Bot 2020-03-05 15:44:04 PST 
All reviewed patches have been landed.  Closing bug.