Bug 208658

Summary: Fix for several failures of LayoutTests in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-03-05 12:26:53 PST 
Fix for several failures of LayoutTests in isolated tree mode.
Comment 1 Andres Gonzalez 2020-03-05 12:32:44 PST 
Created attachment 392606 [details]
Patch
Comment 2 Andres Gonzalez 2020-03-05 13:23:43 PST 
Created attachment 392615 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-05 14:29:50 PST 
The commit-queue encountered the following flaky tests while processing attachment 392615 [details]:

editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-03-05 14:30:08 PST 
The commit-queue encountered the following flaky tests while processing attachment 392615 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-03-05 14:50:36 PST 
Comment on attachment 392615 [details]
Patch

Clearing flags on attachment: 392615

Committed r257948: <https://trac.webkit.org/changeset/257948>
Comment 6 WebKit Commit Bot 2020-03-05 14:50:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-05 14:51:27 PST 
<rdar://problem/60101614>
Comment 8 Simon Fraser (smfr) 2020-03-05 15:02:15 PST 
Comment on attachment 392615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392615&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:830
> +    ScrollView* scrollView() const override;

Is this called off the main thread?
Comment 9 Andres Gonzalez 2020-03-05 15:09:48 PST 
(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 392615 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392615&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:830
> > +    ScrollView* scrollView() const override;
> 
> Is this called off the main thread?

no, it is called in a lambda dispatched to the main thread with:

return Accessibility::retrieveAutoreleasedValueFromMainThread<id>(...)

The implementation in the IsolatedObject will assert if it is not on the main thread.