Bug 208634

Summary: [iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing youennf: commit-queue+

youenn fablet
Reported 2020-03-05 04:55:21 PST
[iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track
Attachments
Patch (7.81 KB, patch)
2020-03-05 04:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.23 KB, patch)
2020-03-10 05:14 PDT, youenn fablet 		youennf: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-03-05 04:58:18 PST
Created attachment 392557 [details] Patch
Eric Carlson
Comment 2 2020-03-05 06:25:21 PST
Comment on attachment 392557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392557&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513 > + // In case of cloning, we might have more than a single source and we do not want one to interrupt the other. What happens if capture is active in the web process? > LayoutTests/platform/ios/TestExpectations:112 > +fast/mediastream/MediaStreamTrack-clone.html [ Pass ] > +fast/mediastream/MediaStream-clone.html [ Pass ] > +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ] Nice!
youenn fablet
Comment 3 2020-03-05 06:50:47 PST
(In reply to Eric Carlson from comment #2) > Comment on attachment 392557 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392557&action=review > > > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513 > > + // In case of cloning, we might have more than a single source and we do not want one to interrupt the other. > > What happens if capture is active in the web process? A different factory will be used so we would not hit this code path. > > LayoutTests/platform/ios/TestExpectations:112 > > +fast/mediastream/MediaStreamTrack-clone.html [ Pass ] > > +fast/mediastream/MediaStream-clone.html [ Pass ] > > +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ] > > Nice!
youenn fablet
Comment 4 2020-03-10 05:14:38 PDT
Created attachment 393137 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-03-10 06:02:58 PDT
Comment on attachment 393137 [details] Patch for landing Clearing flags on attachment: 393137 Committed r258202: <https://trac.webkit.org/changeset/258202>
WebKit Commit Bot
Comment 6 2020-03-10 06:02:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-10 06:03:13 PDT
<rdar://problem/60270248>
Note You need to log in before you can comment on or make changes to this bug.