Bug 208634 - [iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track
Summary: [iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 04:55 PST by youenn fablet
Modified: 2020-03-10 06:12 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.81 KB, patch)
2020-03-05 04:58 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.23 KB, patch)
2020-03-10 05:14 PDT, youenn fablet 		youennf: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-05 04:55:21 PST 
[iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track
Comment 1 youenn fablet 2020-03-05 04:58:18 PST 
Created attachment 392557 [details]
Patch
Comment 2 Eric Carlson 2020-03-05 06:25:21 PST 
Comment on attachment 392557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392557&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513
> +    // In case of cloning, we might have more than a single source and we do not want one to interrupt the other.

What happens if capture is active in the web process?

> LayoutTests/platform/ios/TestExpectations:112
> +fast/mediastream/MediaStreamTrack-clone.html [ Pass ]
> +fast/mediastream/MediaStream-clone.html [ Pass ]
> +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ]

Nice!
Comment 3 youenn fablet 2020-03-05 06:50:47 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 392557 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392557&action=review
> 
> > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513
> > +    // In case of cloning, we might have more than a single source and we do not want one to interrupt the other.
> 
> What happens if capture is active in the web process?

A different factory will be used so we would not hit this code path.

> > LayoutTests/platform/ios/TestExpectations:112
> > +fast/mediastream/MediaStreamTrack-clone.html [ Pass ]
> > +fast/mediastream/MediaStream-clone.html [ Pass ]
> > +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ]
> 
> Nice!
Comment 4 youenn fablet 2020-03-10 05:14:38 PDT 
Created attachment 393137 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-03-10 06:02:58 PDT 
Comment on attachment 393137 [details]
Patch for landing

Clearing flags on attachment: 393137

Committed r258202: <https://trac.webkit.org/changeset/258202>
Comment 6 WebKit Commit Bot 2020-03-10 06:02:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-10 06:03:13 PDT 
<rdar://problem/60270248>