Bug 208629

Summary: AX: Provide a way to run tests in isolated tree mode
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, commit-queue, dmazzoni, ews-watchlist, glenn, jbedard, jcraig, jdiggs, rniwa, samuel_white, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

chris fleizach
Reported 2020-03-05 00:55:26 PST
Accessibility isolated tree mode is a bit difficult to test, because it relies on specific requests entering the system on a secondary thread. To simulate this environment, we need a new argument to pass into test runner that can set it up correctly.
Attachments
patch (18.11 KB, patch)
2020-03-05 01:04 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (18.14 KB, patch)
2020-03-05 01:09 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (18.19 KB, patch)
2020-03-05 07:37 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (18.19 KB, patch)
2020-03-05 07:56 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-05 00:55:36 PST
<rdar://problem/60075583>
chris fleizach
Comment 2 2020-03-05 01:04:05 PST
Created attachment 392544 [details] patch
chris fleizach
Comment 3 2020-03-05 01:09:16 PST
Created attachment 392545 [details] patch
Stephan Szabo
Comment 4 2020-03-05 07:34:31 PST
Comment on attachment 392545 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=392545&action=review > Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:35 > +#include <pal/spi/mac/HIServicesSPI.h> This appears to be breaking on GTK and WinCairo, should it be behind #if ENABLE(ACCESSIBILITY_ISOLATED_TREE) ?
chris fleizach
Comment 5 2020-03-05 07:37:37 PST
Created attachment 392566 [details] patch
chris fleizach
Comment 6 2020-03-05 07:56:01 PST
Created attachment 392569 [details] patch
Ryosuke Niwa
Comment 7 2020-03-06 19:16:20 PST
Comment on attachment 392569 [details] patch Seems okay to me.
WebKit Commit Bot
Comment 8 2020-03-07 10:35:02 PST
Comment on attachment 392569 [details] patch Clearing flags on attachment: 392569 Committed r258075: <https://trac.webkit.org/changeset/258075>
WebKit Commit Bot
Comment 9 2020-03-07 10:35:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.