Bug 208626

Summary:

[WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebKit Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, jiewen_tan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none

Description Jiewen Tan 2020-03-04 23:55:58 PST

Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:].

Comment 1 Radar WebKit Bug Importer 2020-03-04 23:56:17 PST

<rdar://problem/60074148>

Comment 2 Jiewen Tan 2020-03-05 00:09:27 PST

Created attachment 392542 [details]
Patch

Comment 3 Brent Fulgham 2020-03-05 14:38:15 PST

Comment on attachment 392542 [details]
Patch

r=me

Comment 4 Jiewen Tan 2020-03-05 15:00:16 PST

Comment on attachment 392542 [details]
Patch

Thanks Brent for the r+.

Comment 5 WebKit Commit Bot 2020-03-05 15:57:34 PST

The commit-queue encountered the following flaky tests while processing attachment 392542 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.

Comment 6 WebKit Commit Bot 2020-03-05 15:58:16 PST

Comment on attachment 392542 [details]
Patch

Clearing flags on attachment: 392542

Committed r257954: <https://trac.webkit.org/changeset/257954>

Comment 7 WebKit Commit Bot 2020-03-05 15:58:17 PST

All reviewed patches have been landed.  Closing bug.