Bug 208626 - [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
Summary: [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAsse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2020-03-04 23:55 PST by Jiewen Tan
Modified: 2020-03-05 15:58 PST (History)
4 users (show)

See Also:

Attachments
Patch (32.31 KB, patch)
2020-03-05 00:09 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-03-04 23:55:58 PST 
Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:].
Comment 1 Radar WebKit Bug Importer 2020-03-04 23:56:17 PST 
<rdar://problem/60074148>
Comment 2 Jiewen Tan 2020-03-05 00:09:27 PST 
Created attachment 392542 [details]
Patch
Comment 3 Brent Fulgham 2020-03-05 14:38:15 PST 
Comment on attachment 392542 [details]
Patch

r=me
Comment 4 Jiewen Tan 2020-03-05 15:00:16 PST 
Comment on attachment 392542 [details]
Patch

Thanks Brent for the r+.
Comment 5 WebKit Commit Bot 2020-03-05 15:57:34 PST 
The commit-queue encountered the following flaky tests while processing attachment 392542 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-03-05 15:58:16 PST 
Comment on attachment 392542 [details]
Patch

Clearing flags on attachment: 392542

Committed r257954: <https://trac.webkit.org/changeset/257954>
Comment 7 WebKit Commit Bot 2020-03-05 15:58:17 PST 
All reviewed patches have been landed.  Closing bug.