| Summary: | Track "scrolling scope" on RenderLayers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, tsavell, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2020-03-04 18:25:49 PST
Created attachment 392526 [details]
Patch
Comment on attachment 392526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392526&action=review > Source/WebCore/ChangeLog:12 > + Each layer has two scopes; a "box" scope that applies to the background/borders, and wouldn't decoration scope be a better name if it is only about background and borders? (In reply to zalan from comment #2) > Comment on attachment 392526 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392526&action=review > > > Source/WebCore/ChangeLog:12 > > + Each layer has two scopes; a "box" scope that applies to the background/borders, and > > wouldn't decoration scope be a better name if it is only about background > and borders? I thought of that, but it's more about the scrolling element's box, which doesn't move. The commit-queue encountered the following flaky tests while processing attachment 392526 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 392526 [details] Patch Clearing flags on attachment: 392526 Committed r257920: <https://trac.webkit.org/changeset/257920> All reviewed patches have been landed. Closing bug. Partially reverted in https://trac.webkit.org/changeset/258229/webkit because it broke gmail. Created attachment 393197 [details]
Patch
Comment on attachment 393197 [details] Patch Clearing flags on attachment: 393197 Committed r258249: <https://trac.webkit.org/changeset/258249> All reviewed patches have been landed. Closing bug. New test added in this commit is flaky, tracking in https://bugs.webkit.org/show_bug.cgi?id=209052 |