Bug 208594

Summary: Adopt new and improved CFNetwork SPI for cookie change notifications
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ggaren, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-03-04 13:19:25 PST
Adopt new and improved CFNetwork SPI for cookie change notifications.
Attachments
Patch (18.51 KB, patch)
2020-03-04 13:27 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.67 KB, patch)
2020-03-04 14:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-04 13:19:42 PST
<rdar://problem/60053313>
Chris Dumez
Comment 2 2020-03-04 13:27:32 PST
Created attachment 392469 [details] Patch
Chris Dumez
Comment 3 2020-03-04 14:26:02 PST
Created attachment 392484 [details] Patch
Chris Dumez
Comment 4 2020-03-04 14:28:15 PST
Comment on attachment 392484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392484&action=review > Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:595 > + if (cookies.isEmpty()) The only change in this latest iteration was early returning here if the list of cookies is empty after filtering out the httpOnly ones. No need to do unnecessary IPC in this case.
WebKit Commit Bot
Comment 5 2020-03-04 15:28:18 PST
Comment on attachment 392484 [details] Patch Clearing flags on attachment: 392484 Committed r257888: <https://trac.webkit.org/changeset/257888>
WebKit Commit Bot
Comment 6 2020-03-04 15:28:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.