Summary: | frame/iframe scrolling attribute does to recognize value "noscroll" or "off" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Component: | DOM | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, masonfreed, mjs, rbuis, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 209178 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2020-03-04 03:08:00 PST
This should be trivial fix. I can take care of this. Created attachment 392550 [details]
WIP Patch
WPT tests haven't arrived yet into the WPT repos, so we need to wait before taking this...
WPT tests are hung up here: https://github.com/web-platform-tests/wpt/pull/22072 Are "off", "noscroll", or "no" synonymous? (In reply to Simon Fraser (smfr) from comment #4) > Are "off", "noscroll", or "no" synonymous? In HTML5, yes (see comment 0). Maybe this was different in HTML4. Created attachment 393825 [details]
Patch
Comment on attachment 393825 [details]
Patch
Approved also since Maciej indicated it as a reasonable change.
Comment on attachment 393825 [details] Patch Clearing flags on attachment: 393825 Committed r258651: <https://trac.webkit.org/changeset/258651> All reviewed patches have been landed. Closing bug. |