Bug 208558

Summary: [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2020-03-03 21:34:31 PST
shrink it!
Attachments
Patch (2.30 KB, patch)
2020-03-04 06:31 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-03 21:35:02 PST
<rdar://problem/60026658>
zalan
Comment 2 2020-03-04 06:31:00 PST
Created attachment 392408 [details] Patch
Antti Koivisto
Comment 3 2020-03-04 06:33:13 PST
Comment on attachment 392408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392408&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > - m_textContent->expand(-1); wut > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > + constexpr size_t trailingTrimmableContentLength = 1; > + m_textContent->shrink(trailingTrimmableContentLength); I have concerns.
zalan
Comment 4 2020-03-04 06:34:12 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 392408 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392408&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > > - m_textContent->expand(-1); > > wut > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > > + constexpr size_t trailingTrimmableContentLength = 1; > > + m_textContent->shrink(trailingTrimmableContentLength); > > I have concerns. Me too!
WebKit Commit Bot
Comment 5 2020-03-04 07:19:20 PST
Comment on attachment 392408 [details] Patch Clearing flags on attachment: 392408 Committed r257841: <https://trac.webkit.org/changeset/257841>
WebKit Commit Bot
Comment 6 2020-03-04 07:19:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.