Bug 208548

Summary: Add signposts for top-level script execution
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, esprehn+autocc, ews-watchlist, kangil.han, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ben Nham
Reported 2020-03-03 17:01:47 PST
Add signposts for top-level script execution
Attachments
Patch (3.30 KB, patch)
2020-03-03 17:08 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2020-03-03 17:08:54 PST
Created attachment 392350 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-03-03 17:09:24 PST
<rdar://problem/60020308>
Ben Nham
Comment 3 2020-03-05 15:04:13 PST
Alex was a bit concerned about the URL being logged in the signpost, but that is pretty important to making the signpost actually useful. It is sensitive data and WTFSignpost takes care of that by not logging the signpost unless a profiling environment variable is set and the code is running on an AppleInternal system.
WebKit Commit Bot
Comment 4 2020-03-05 16:02:54 PST
Comment on attachment 392350 [details] Patch Clearing flags on attachment: 392350 Committed r257955: <https://trac.webkit.org/changeset/257955>
WebKit Commit Bot
Comment 5 2020-03-05 16:02:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.