Bug 208544

Summary: commit-queue should run WK2 tests instead of WK1 tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208716
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-03-03 16:01:05 PST
commit-queue should run WK2 tests instead of WK1 tests. As per https://bugs.webkit.org/show_bug.cgi?id=208521#c7: "there are now many WebKit2 only features and more code in WebKit2 itself. So I also think that we should switch CQ to WebKit2."
Attachments
Patch (1.27 KB, patch)
2020-03-03 16:10 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-03 16:10:43 PST
Created attachment 392346 [details] Patch
Jonathan Bedard
Comment 2 2020-03-04 07:40:57 PST
I'd like Alexey to confirm the original rationale, which I suspect was that WebKit1 tests were more stable and better gardened.
Jonathan Bedard
Comment 3 2020-03-04 07:41:47 PST
(In reply to Jonathan Bedard from comment #2) > I'd like Alexey to confirm the original rationale, which I suspect was that > WebKit1 tests were more stable and better gardened. Didn't read through all my email: "IIRC they were gardened equally well, but we knew that WebKit2 ran fewer tests because of unimplemented WebKitTestRunner functionality. That's still true as far as functionality goes, but there are now many WebKit2 only features and more code in WebKit2 itself. So I also think that we should switch CQ to WebKit2."
Alexey Proskuryakov
Comment 4 2020-03-04 09:54:02 PST
Please do send a heads up to webkit-dev.
WebKit Commit Bot
Comment 5 2020-03-05 10:28:51 PST
Committed r257927: <https://trac.webkit.org/changeset/257927> All reviewed patches have been landed. Closing bug and clearing flags on attachment 392346 [details].
Radar WebKit Bug Importer
Comment 6 2020-03-05 10:29:36 PST
<rdar://problem/60089536>
Note You need to log in before you can comment on or make changes to this bug.