Bug 208537

Summary: Refactor FixedVMPoolExecutableAllocator to not have member functions which are really just helper functions
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208490    
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2020-03-03 14:19:19 PST
This will make it easier when implementing the 1GB executable space on arm64
Attachments
patch (26.45 KB, patch)
2020-03-03 14:41 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (26.45 KB, patch)
2020-03-03 15:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-03-03 14:19:53 PST
*** Bug 208116 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 2 2020-03-03 14:41:00 PST
Created attachment 392336 [details] patch
Saam Barati
Comment 3 2020-03-03 14:57:59 PST
Comment on attachment 392336 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=392336&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:405 > private: will fix the double "private:" in a row
Mark Lam
Comment 4 2020-03-03 15:02:47 PST
Comment on attachment 392336 [details] patch r=me
Saam Barati
Comment 5 2020-03-03 15:09:17 PST
Created attachment 392339 [details] patch for landing
WebKit Commit Bot
Comment 6 2020-03-03 16:18:35 PST
Comment on attachment 392339 [details] patch for landing Clearing flags on attachment: 392339 Committed r257812: <https://trac.webkit.org/changeset/257812>
WebKit Commit Bot
Comment 7 2020-03-03 16:18:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-03 16:19:17 PST
<rdar://problem/60018354>
Note You need to log in before you can comment on or make changes to this bug.