Bug 208535

Summary: [ews] Add build step to generate commit message
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208514
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-03-03 13:48:20 PST
[ews] Add build step to find generate commit message for commit-queue.
Attachments
Patch (7.72 KB, patch)
2020-03-03 14:07 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-03 14:07:15 PST
Created attachment 392326 [details] Patch
Aakash Jain
Comment 2 2020-03-03 14:09:30 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1057
Jonathan Bedard
Comment 3 2020-03-03 15:15:36 PST
Comment on attachment 392326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392326&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2482 > + self.command = 'perl Tools/Scripts/commit-log-editor --print-log {} > {}'.format(modified_changelogs, commit_message_filename) It feels wrong to place the commit message in a temp file only to be used in the next step. Was this what the previous code did? How do we know that tmp won't be cleared out between this step and the next? Any reason we can't stick this output in property to be used by the next step?
Aakash Jain
Comment 4 2020-03-04 09:41:20 PST
Included this change in https://bugs.webkit.org/show_bug.cgi?id=208539
Note You need to log in before you can comment on or make changes to this bug.