Summary: | Web Inspector: setting the frontend appearance doesn't update the window when undocked | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 186308 | ||||||||
Bug Blocks: | 208557 | ||||||||
Attachments: |
|
Description
Devin Rousso
2020-03-03 00:07:34 PST
Created attachment 392253 [details]
Patch
Comment on attachment 392253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392253&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:239 > + m_frontendPage->setUseDarkAppearanceOverride(false); You should not need to do this if you force the appearance on the window. > Source/WebCore/inspector/InspectorFrontendHost.cpp:247 > + m_frontendPage->setUseDarkAppearanceOverride(true); Ditto. > Source/WebCore/inspector/InspectorFrontendHost.cpp:254 > m_frontendPage->setUseDarkAppearanceOverride(WTF::nullopt); Ditto. Created attachment 392303 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 392303 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 392303 [details] Patch Clearing flags on attachment: 392303 Committed r257801: <https://trac.webkit.org/changeset/257801> All reviewed patches have been landed. Closing bug. |