Bug 208462

Summary: Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, Lawrence.j, samuel_white, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2020-03-02 12:29:43 PST
Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
Attachments
Patch (20.88 KB, patch)
2020-03-02 13:05 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (21.14 KB, patch)
2020-03-02 18:51 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (21.11 KB, patch)
2020-03-08 10:48 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-03-02 13:05:27 PST
Created attachment 392177 [details] Patch
Andres Gonzalez
Comment 2 2020-03-02 18:51:02 PST
Created attachment 392240 [details] Patch
WebKit Commit Bot
Comment 3 2020-03-02 20:07:47 PST
Comment on attachment 392240 [details] Patch Clearing flags on attachment: 392240 Committed r257760: <https://trac.webkit.org/changeset/257760>
WebKit Commit Bot
Comment 4 2020-03-02 20:07:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-02 20:08:18 PST
<rdar://problem/59980673>
Jason Lawrence
Comment 6 2020-03-06 12:40:51 PST
Reverted r257760 for reason: This commit caused flaky crashing on Mac wk2. Committed r258019: <https://trac.webkit.org/changeset/258019>
Simon Fraser (smfr)
Comment 7 2020-03-07 10:21:28 PST
Several tests are crashing after this rollout: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r258071%20(8028)/results.html
Andres Gonzalez
Comment 8 2020-03-08 10:48:57 PDT
Created attachment 392959 [details] Patch
Andres Gonzalez
Comment 9 2020-03-08 10:55:23 PDT
The cause of test failures is not directly related to this patch and is addressed with a new patch for bug: https://bugs.webkit.org/show_bug.cgi?id=208648 Re-applying this patch.
WebKit Commit Bot
Comment 10 2020-03-08 12:08:17 PDT
Comment on attachment 392959 [details] Patch Clearing flags on attachment: 392959 Committed r258108: <https://trac.webkit.org/changeset/258108>
WebKit Commit Bot
Comment 11 2020-03-08 12:08:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.